chore(anvil): mostly remove EthTransactionRequest usage, migrate AccessListTracer
#6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jan 12, 2024
DaniPopes
reviewed
Jan 12, 2024
| request.data.as_ref().map(|data| data.as_ref().is_empty()).unwrap_or(true); | ||
| // If the request is a simple native token transfer we can optimize | ||
| // We assume it's a transfer if we have no input data. | ||
| let likely_transfer = request.input.clone().into_input().is_none(); |
There was a problem hiding this comment.
Suggested change
| let likely_transfer = request.input.clone().into_input().is_none(); | |
| let likely_transfer = request.input.input().is_none(); |
gakonst
reviewed
Jan 16, 2024
Comment on lines
+31
to
+35
| pub fn alloy_to_revm_access_list(list: Vec<AlloyAccessListItem>) -> Vec<(Address, Vec<U256>)> { | ||
| list.into_iter() | ||
| .map(|item| (item.address, item.storage_keys.into_iter().map(|k| k.into()).collect())) | ||
| .collect() | ||
| } |
There was a problem hiding this comment.
we should ideally make the Alloy Access List compatible with the Revm type directly or with a .into() impl
| request.data.as_ref().map(|data| data.as_ref().is_empty()).unwrap_or(true); | ||
| // If the request is a simple native token transfer we can optimize | ||
| // We assume it's a transfer if we have no input data. | ||
| let likely_transfer = request.input.clone().into_input().is_none(); |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #6715.
Solution
Removes
EthTransactionRequestusage everywhere where its capability to produceTypedTransactions is not required, as this type will be migrated later along with typed receipt, and the block types. This removes a bunch of conversions throughout the API / in-mem backend. Also migrates theAccessListTracer.